Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 15740034: Print output of all commands if a testcase failed (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print output of all commands if a testcase failed R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23408

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M tools/testing/dart/test_progress.dart View 1 1 chunk +31 lines, -25 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
https://codereview.chromium.org/15740034/diff/2001/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/15740034/diff/2001/tools/testing/dart/test_progress.dart#newcode97 tools/testing/dart/test_progress.dart:97: output.add("CommandOutput[$i]:"); Do we want to print this always or ...
7 years, 6 months ago (2013-05-30 13:03:34 UTC) #1
ricow1
https://codereview.chromium.org/15740034/diff/2001/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/15740034/diff/2001/tools/testing/dart/test_progress.dart#newcode97 tools/testing/dart/test_progress.dart:97: output.add("CommandOutput[$i]:"); On 2013/05/30 13:03:34, kustermann wrote: > Do we ...
7 years, 6 months ago (2013-05-30 13:14:10 UTC) #2
ricow1
and lgtm
7 years, 6 months ago (2013-05-30 13:14:17 UTC) #3
kustermann
7 years, 6 months ago (2013-05-30 13:15:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698