Address additional comments to tarball creation script

Address additional comments to tarball creation script

R=kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=32418

[kustermann, 2014-02-07 10:10:14]

LGTM

https://codereview.chromium.org/157383002/diff/1/tools/create_tarball.py
File tools/create_tarball.py (right):

https://codereview.chromium.org/157383002/diff/1/tools/create_tarball.py#newc...
tools/create_tarball.py:35: DART_ROOT = realpath(join(SCRIPT_DIR, '..'))
We usually do it like this (see e.g. tools/utils.py), it's a bit cleaner and
less error prone (e.g. if this file is not called directly but rather imported
by another python script):

DART_DIR = os.path.abspath(os.path.join(__file__, '..', '..'))

https://codereview.chromium.org/157383002/diff/1/tools/create_tarball.py#newc...
tools/create_tarball.py:116: original_name = tar_info.name[len(DART_ROOT):]
Add an assert before that:

  assert tar_info.name.startswith(DART_ROOT)

[Søren Gjesse, 2014-02-07 12:02:51]

https://codereview.chromium.org/157383002/diff/1/tools/create_tarball.py
File tools/create_tarball.py (right):

https://codereview.chromium.org/157383002/diff/1/tools/create_tarball.py#newc...
tools/create_tarball.py:35: DART_ROOT = realpath(join(SCRIPT_DIR, '..'))
On 2014/02/07 10:10:14, kustermann wrote:
> We usually do it like this (see e.g. tools/utils.py), it's a bit cleaner and
> less error prone (e.g. if this file is not called directly but rather imported
> by another python script):
> 
> DART_DIR = os.path.abspath(os.path.join(__file__, '..', '..'))

Done (build.py still uses the other pattern)

https://codereview.chromium.org/157383002/diff/1/tools/create_tarball.py#newc...
tools/create_tarball.py:116: original_name = tar_info.name[len(DART_ROOT):]
On 2014/02/07 10:10:14, kustermann wrote:
> Add an assert before that:
> 
>   assert tar_info.name.startswith(DART_ROOT)

Done.

[Søren Gjesse, 2014-02-07 12:03:52]

Committed patchset #2 manually as r32418 (presubmit successful).