Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 15736011: Create test isolates using a snapshot, this ensures that we do not depend (Closed)

Created:
7 years, 7 months ago by siva
Modified:
7 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create test isolates using a snapshot, this ensures that we do not depend on the location of core libraries which can be a problem when we copy the run_vm_tests executable to a different machine. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23030

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M runtime/tests/vm/vm.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/unit_test.h View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 7 months ago (2013-05-22 16:42:33 UTC) #1
siva
7 years, 7 months ago (2013-05-22 17:09:10 UTC) #2
zra
lgtm
7 years, 7 months ago (2013-05-22 17:11:49 UTC) #3
siva
7 years, 7 months ago (2013-05-22 17:25:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23030 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698