Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 15735003: Use assertSubtype for lists. (Closed)

Created:
7 years, 7 months ago by karlklose
Modified:
7 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use assertSubtype for lists. Also omit access to as-fields if possible. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=23014

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +4 lines, -5 lines 0 comments Download
A + tests/language/generic_list_checked_test.dart View 1 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 7 months ago (2013-05-22 12:01:12 UTC) #1
Johnni Winther
lgtm
7 years, 7 months ago (2013-05-22 12:18:58 UTC) #2
karlklose
7 years, 7 months ago (2013-05-22 13:10:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23014 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698