Require exact match of vm arguments.

Require exact match of vm arguments.

This will make sure e.g. '--verbose-gc' won't trigger '--verbose'.

BUG=
R=iposva@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23845

[Anders Johnsen, 2013-06-11 08:03:32]

This fixes an error introduced by
https://code.google.com/p/dart/source/detail?r=23831.

[Søren Gjesse, 2013-06-11 08:35:00]

lgtm

[Ivan Posva, 2013-06-11 09:55:49]

https://codereview.chromium.org/15724022/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/15724022/diff/1/runtime/bin/main.cc#newcode265
runtime/bin/main.cc:265: if (option_length == length && strncmp(option, name,
length) == 0) {
Please keep the parens.

How will this match "--snapshot=snapshotfile" to "--snapshot=" now?

[Anders Johnsen, 2013-06-11 10:44:31]

PTAL

https://codereview.chromium.org/15724022/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/15724022/diff/1/runtime/bin/main.cc#newcode265
runtime/bin/main.cc:265: if (option_length == length && strncmp(option, name,
length) == 0) {
On 2013/06/11 09:55:49, Ivan Posva wrote:
> Please keep the parens.
> 
> How will this match "--snapshot=snapshotfile" to "--snapshot=" now?

Done. I see, updated.

[Ivan Posva, 2013-06-11 11:44:29]

LGTM with comment.

-Ivan

https://codereview.chromium.org/15724022/diff/6001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/15724022/diff/6001/runtime/bin/main.cc#newcod...
runtime/bin/main.cc:266: if (main_options[i].process(option + length)) return
true;
{
  return true;
}

[Anders Johnsen, 2013-06-11 11:55:41]

https://codereview.chromium.org/15724022/diff/6001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/15724022/diff/6001/runtime/bin/main.cc#newcod...
runtime/bin/main.cc:266: if (main_options[i].process(option + length)) return
true;
On 2013/06/11 11:44:29, Ivan Posva wrote:
> {
>   return true;
> }

Done.

[Anders Johnsen, 2013-06-11 11:55:50]

Committed patchset #3 manually as r23845 (presubmit successful).