Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 157223004: Add annotated steps for src tarball creation bot (Closed)

Created:
6 years, 10 months ago by ricow1
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add annotated steps for src tarball creation bot This will also include building the debian package, but this is just to get us going. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32410

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M client/tools/buildbot_annotated_steps.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/bots/bot.py View 1 chunk +2 lines, -1 line 0 comments Download
A tools/bots/src-tarball.py View 1 chunk +42 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
6 years, 10 months ago (2014-02-07 07:04:01 UTC) #1
Søren Gjesse
lgtm
6 years, 10 months ago (2014-02-07 07:34:32 UTC) #2
ricow1
Committed patchset #1 manually as r32410 (presubmit successful).
6 years, 10 months ago (2014-02-07 08:13:26 UTC) #3
Bill Hesse
lgtm
6 years, 10 months ago (2014-02-07 09:13:39 UTC) #4
kustermann
https://codereview.chromium.org/157223004/diff/1/tools/bots/src-tarball.py File tools/bots/src-tarball.py (right): https://codereview.chromium.org/157223004/diff/1/tools/bots/src-tarball.py#newcode1 tools/bots/src-tarball.py:1: #!/usr/bin/python As mentioned on another CL, we should never ...
6 years, 10 months ago (2014-02-11 10:25:28 UTC) #5
ricow1
6 years, 10 months ago (2014-02-11 10:36:45 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/157223004/diff/1/tools/bots/src-tarball.py
File tools/bots/src-tarball.py (right):

https://codereview.chromium.org/157223004/diff/1/tools/bots/src-tarball.py#ne...
tools/bots/src-tarball.py:1: #!/usr/bin/python
On 2014/02/11 10:25:28, kustermann wrote:
> As mentioned on another CL, we should never use dashes in python module names.
> (e.g. you cannot say "import src-tarball", but you can say "import
> src_tarball").
> 
> Could we rename this to "src_tarball.py"?
Sure, lets just do that

Powered by Google App Engine
This is Rietveld 408576698