Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 15719004: Fix http_server_early_client_close_test. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, dgrove
Visibility:
Public.

Description

Fix http_server_early_client_close_test. A too early close of the HttpServer was responsible for an uncought socket error. We now wait with HttpServer close to we 1) Have sent all data to the server. 2) The server are done receiving all data for the potential request. BUG=http://code.google.com/p/dart/issues/detail?id=10408 Committed: https://code.google.com/p/dart/source/detail?r=23196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M tests/standalone/io/http_server_early_client_close_test.dart View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
TBR
7 years, 7 months ago (2013-05-25 20:22:40 UTC) #1
Anders Johnsen
Committed patchset #1 manually as r23196 (presubmit successful).
7 years, 7 months ago (2013-05-26 05:29:53 UTC) #2
Søren Gjesse
7 years, 7 months ago (2013-05-27 06:11:40 UTC) #3
Søren Gjesse
7 years, 7 months ago (2013-05-27 06:27:48 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698