Issue 15719002: Provide a POSIX-compliant implementation of Directory::Current.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15719002: Provide a POSIX-compliant implementation of Directory::Current. (Closed)

Created:
7 years, 7 months ago by podivilov

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Provide a POSIX-compliant implementation of Directory::Current. R=sgjesse@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23024

Patch Set 2 : . #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	runtime/bin/directory_linux.cc	View	1	1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/15719002/diff/1/runtime/bin/directory_linux.cc File runtime/bin/directory_linux.cc (right): https://codereview.chromium.org/15719002/diff/1/runtime/bin/directory_linux.cc#newcode419 runtime/bin/directory_linux.cc:419: size_t size = 1024; Use an initial size ...

7 years, 7 months ago (2013-05-22 14:39:34 UTC) #3

podivilov

Committed patchset #2 manually as r23024 (presubmit successful).

7 years, 7 months ago (2013-05-22 16:09:51 UTC) #4

podivilov

7 years, 7 months ago (2013-05-22 17:05:13 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15719002/diff/1/runtime/bin/directory_linux.cc
File runtime/bin/directory_linux.cc (right):

https://codereview.chromium.org/15719002/diff/1/runtime/bin/directory_linux.c...
runtime/bin/directory_linux.cc:419: size_t size = 1024;
On 2013/05/22 14:39:34, Søren Gjesse wrote:
> Use an initial size of PATH_MAX?

Done.

Expand Messages | Collapse Messages

Issue 15719002: Provide a POSIX-compliant implementation of Directory::Current. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages