Issue 157053007: - Zap the allocated object when allocating uninitialized memory in debug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157053007: - Zap the allocated object when allocating uninitialized memory in debug. (Closed)

Created:
6 years, 10 months ago by Ivan Posva

Modified:
6 years, 10 months ago

Reviewers:
regis, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Zap the allocated object when allocating uninitialized memory in debug. - Do not run any smart code when recreating type arguments from a snapshot. - Adjust assertions. R=asiva@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=32510

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -3 lines)			Patch
M	runtime/vm/object.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/157053007/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/157053007/diff/1/runtime/vm/snapshot.cc#newcode729 runtime/vm/snapshot.cc:729: uword end = address + size; You could ...

6 years, 10 months ago (2014-02-10 17:49:04 UTC) #2

Ivan Posva

6 years, 10 months ago (2014-02-10 18:40:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r32510 (presubmit successful).

Expand Messages | Collapse Messages