Issue 15698002: Update process_exit_negative_test to latest API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15698002: Update process_exit_negative_test to latest API. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update process_exit_negative_test to latest API. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=22993

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	tests/standalone/io/process_exit_negative_test.dart	View		1 chunk	+6 lines, -6 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/15698002/diff/1/tests/standalone/io/process_exit_negative_test.dart File tests/standalone/io/process_exit_negative_test.dart (right): https://codereview.chromium.org/15698002/diff/1/tests/standalone/io/process_exit_negative_test.dart#newcode12 tests/standalone/io/process_exit_negative_test.dart:12: var fp = Process.start(getProcessTestFileName(), why change that?

7 years, 7 months ago (2013-05-22 08:11:18 UTC) #2

Anders Johnsen

https://codereview.chromium.org/15698002/diff/1/tests/standalone/io/process_exit_negative_test.dart File tests/standalone/io/process_exit_negative_test.dart (right): https://codereview.chromium.org/15698002/diff/1/tests/standalone/io/process_exit_negative_test.dart#newcode12 tests/standalone/io/process_exit_negative_test.dart:12: var fp = Process.start(getProcessTestFileName(), On 2013/05/22 08:11:18, ricow1 wrote: ...

7 years, 7 months ago (2013-05-22 08:14:06 UTC) #3

Anders Johnsen

7 years, 7 months ago (2013-05-22 08:14:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22993 (presubmit successful).

Expand Messages | Collapse Messages