Issue 156973002: Fix bot breakage: math unary instruction has side effect and therefore cannot be eliminated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156973002: Fix bot breakage: math unary instruction has side effect and therefore cannot be eliminated (Closed)

Created:
6 years, 10 months ago by srdjan

Modified:
6 years, 10 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bot breakage: math unary instruction has side effects (throws exception if argument is not a number) and therefore cannot be eliminated if there are no uses. Committed: https://code.google.com/p/dart/source/detail?r=32382

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #1 manually as r32382 (presubmit successful).

6 years, 10 months ago (2014-02-06 20:55:20 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages