Issue 15697009: Enable code optimization on ARM.

Issue 15697009: Enable code optimization on ARM. (Closed)

Created:
7 years, 7 months ago by regis

Modified:
7 years, 7 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enable code optimization on ARM. Disable failing tests. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23037

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+373 lines, -75 lines)			Patch
M	runtime/tests/vm/vm.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View		4 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View		4 chunks	+115 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	8 chunks	+175 lines, -33 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		6 chunks	+68 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/15697009/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/15697009/diff/1/runtime/vm/intermediate_language_arm.cc#newcode508 runtime/vm/intermediate_language_arm.cc:508: __ b(&load_true, cond); Could you use conditional execution ...

7 years, 7 months ago (2013-05-22 18:28:08 UTC) #2

regis

Thanks! https://codereview.chromium.org/15697009/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/15697009/diff/1/runtime/vm/intermediate_language_arm.cc#newcode508 runtime/vm/intermediate_language_arm.cc:508: __ b(&load_true, cond); On 2013/05/22 18:28:08, zra wrote: ...

7 years, 7 months ago (2013-05-22 18:40:29 UTC) #3

regis

7 years, 7 months ago (2013-05-22 18:53:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r23037 (presubmit successful).

Expand Messages | Collapse Messages