Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15689013: - Modify dart_api.h to be a proper C API. (Closed)

Created:
7 years, 6 months ago by Ivan Posva
Modified:
7 years, 6 months ago
Reviewers:
Anton Muhin, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Modify dart_api.h to be a proper C API. - Verify that dart_api.h can be used from C by changing the test_extension to be a pure C file. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23476

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -765 lines) Patch
M runtime/bin/bin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/crypto.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dartutils.h View 1 7 chunks +42 lines, -41 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 2 3 13 chunks +24 lines, -24 lines 0 comments Download
M runtime/bin/directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file.cc View 3 chunks +15 lines, -14 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/io_buffer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + runtime/bin/test_extension.c View 3 chunks +23 lines, -19 lines 0 comments Download
D runtime/bin/test_extension.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M runtime/include/dart_api.h View 1 2 3 43 chunks +218 lines, -230 lines 0 comments Download
M runtime/lib/isolate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 5 chunks +42 lines, -42 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 19 chunks +41 lines, -33 lines 0 comments Download
M runtime/vm/dart_api_message.h View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 31 chunks +82 lines, -82 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 55 chunks +189 lines, -189 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
7 years, 6 months ago (2013-05-31 00:58:46 UTC) #1
siva
lgtm https://codereview.chromium.org/15689013/diff/1/runtime/bin/dartutils.h File runtime/bin/dartutils.h (right): https://codereview.chromium.org/15689013/diff/1/runtime/bin/dartutils.h#newcode353 runtime/bin/dartutils.h:353: I think there are some indentation issues with ...
7 years, 6 months ago (2013-05-31 01:12:41 UTC) #2
Ivan Posva
https://codereview.chromium.org/15689013/diff/1/runtime/bin/dartutils.h File runtime/bin/dartutils.h (right): https://codereview.chromium.org/15689013/diff/1/runtime/bin/dartutils.h#newcode353 runtime/bin/dartutils.h:353: On 2013/05/31 01:12:41, siva wrote: > I think there ...
7 years, 6 months ago (2013-05-31 04:35:46 UTC) #3
Ivan Posva
7 years, 6 months ago (2013-05-31 16:36:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as r23476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698