Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 15688013: Remove the HttpRequest.queryParameters getter (Closed)

Created:
7 years, 6 months ago by Søren Gjesse
Modified:
7 years, 6 months ago
Reviewers:
nweiz, Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the HttpRequest.queryParameters getter The parsed query parameters are now now available from the Uri object. TBR=whesse@google.com BUG=http://dartbug/2641 Committed: https://code.google.com/p/dart/source/detail?r=23413

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M pkg/http/test/safe_http_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/http/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/lib/oauth2.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/safe_http_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M tests/standalone/io/http_keep_alive_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
https://codereview.chromium.org/15688013/diff/1/pkg/oauth2/lib/oauth2.dart File pkg/oauth2/lib/oauth2.dart (right): https://codereview.chromium.org/15688013/diff/1/pkg/oauth2/lib/oauth2.dart#newcode99 pkg/oauth2/lib/oauth2.dart:99: /// return grant.handleAuthorizationResponse(request.uri.queryParameters); I decided to keep the long ...
7 years, 6 months ago (2013-05-30 10:42:53 UTC) #1
Bill Hesse
LGTM. You lose a cache, but that shouldn't be important.
7 years, 6 months ago (2013-05-30 11:23:40 UTC) #2
Søren Gjesse
On 2013/05/30 11:23:40, Bill Hesse wrote: > LGTM. You lose a cache, but that shouldn't ...
7 years, 6 months ago (2013-05-30 11:27:23 UTC) #3
Søren Gjesse
Committed patchset #1 manually as r23413 (presubmit successful).
7 years, 6 months ago (2013-05-30 13:39:35 UTC) #4
nweiz
7 years, 6 months ago (2013-05-30 17:40:52 UTC) #5
Message was sent while issue was closed.
pkg changes lgtm

Powered by Google App Engine
This is Rietveld 408576698