Issue 156863006: Step 1 in removing the old dartdoc code from repo.

Issue 156863006: Step 1 in removing the old dartdoc code from repo. (Closed)

Created:
6 years, 10 months ago by dgrove

Modified:
6 years, 10 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Step 1 in removing the old dartdoc code from repo. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32387

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -116 lines)			Patch
M	dart.gyp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	utils/apidoc/apidoc.gyp	View	1 chunk	+0 lines, -108 lines	0 comments	Download
M	utils/apidoc/docgen.gyp	View	3 chunks	+3 lines, -5 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm, with one comment https://codereview.chromium.org/156863006/diff/1/utils/apidoc/docgen.gyp File utils/apidoc/docgen.gyp (right): https://codereview.chromium.org/156863006/diff/1/utils/apidoc/docgen.gyp#newcode79 utils/apidoc/docgen.gyp:79: '../../pkg/docgen/bin/docgen.dart', is there any reason ...

6 years, 10 months ago (2014-02-06 21:50:45 UTC) #2

dgrove

On 2014/02/06 21:50:45, Emily Fortuna wrote: > lgtm, with one comment > > https://codereview.chromium.org/156863006/diff/1/utils/apidoc/docgen.gyp > ...

6 years, 10 months ago (2014-02-06 22:00:04 UTC) #3

dgrove

Committed patchset #1 manually as r32387 (presubmit successful).

6 years, 10 months ago (2014-02-06 22:00:42 UTC) #4

Alan Knight

6 years, 10 months ago (2014-02-06 22:21:56 UTC) #5

Message was sent while issue was closed.

lgtm, one nit

https://codereview.chromium.org/156863006/diff/1/utils/apidoc/docgen.gyp
File utils/apidoc/docgen.gyp (right):

https://codereview.chromium.org/156863006/diff/1/utils/apidoc/docgen.gyp#newc...
utils/apidoc/docgen.gyp:79: '../../pkg/docgen/bin/docgen.dart',
I deliberately had it running from the snapshot as a way of exercising the
snapshot. But if you don't think that's important we can do it this way.

Expand Messages | Collapse Messages