Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 15685004: Only update dom.json when executing from go.sh. (Closed)

Created:
7 years, 7 months ago by blois
Modified:
7 years, 7 months ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Only update dom.json when executing from go.sh. BUG= R=antonm@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=23099

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M tools/dom/scripts/dartdomgenerator.py View 1 4 chunks +10 lines, -3 lines 0 comments Download
M tools/dom/scripts/go.sh View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
Note that dom.json should only be changing when building Dartium when the APIs are out ...
7 years, 7 months ago (2013-05-22 18:33:36 UTC) #1
vsm
LGTM, but you'll need a corresponding Dartium change https://codereview.chromium.org/15685004/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (right): https://codereview.chromium.org/15685004/diff/1/tools/dom/scripts/dartdomgenerator.py#newcode52 tools/dom/scripts/dartdomgenerator.py:52: dartium_output_dir, ...
7 years, 7 months ago (2013-05-22 23:21:17 UTC) #2
Anton Muhin
lgtm
7 years, 7 months ago (2013-05-23 17:47:42 UTC) #3
blois
https://codereview.chromium.org/15685004/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (right): https://codereview.chromium.org/15685004/diff/1/tools/dom/scripts/dartdomgenerator.py#newcode52 tools/dom/scripts/dartdomgenerator.py:52: dartium_output_dir, update_dom_metadata): On 2013/05/22 23:21:17, vsm wrote: > Note, ...
7 years, 7 months ago (2013-05-23 20:26:55 UTC) #4
blois
7 years, 7 months ago (2013-05-23 20:30:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r23099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698