Issue 156813002: Cleaning up warnings from the analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156813002: Cleaning up warnings from the analyzer. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Cleaning up warnings from the analyzer. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32399

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -8 lines)			Patch
	M	sdk/lib/_internal/lib/constant_map.dart	View	1 2	4 chunks	+15 lines, -4 lines	0 comments	Download
	M	sdk/lib/_internal/lib/js_helper.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

sra1

I'd say submit the js_helper change (with 'return expression') but hold off on the constant_map ...

6 years, 10 months ago (2014-02-06 20:00:33 UTC) #2

Emily Fortuna

6 years, 10 months ago (2014-02-07 00:56:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r32399 (presubmit successful).