Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 15680002: Remove explicit delayed futures in dart:io. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove explicit delayed futures in dart:io. After the change of Completers always being delayed to the next tick, this is no longer needed. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -88 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 16 chunks +22 lines, -60 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 4 chunks +2 lines, -8 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 3 chunks +5 lines, -8 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-22 06:58:43 UTC) #1
Søren Gjesse
LGTM!! Nice cleanup - thanks!
7 years, 7 months ago (2013-05-22 07:19:18 UTC) #2
Anders Johnsen
7 years, 7 months ago (2013-05-22 07:23:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698