Issue 15679024: Improve toString on mirrors and align VM and dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15679024: Improve toString on mirrors and align VM and dart2js. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org, gbracha

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve toString on mirrors and align VM and dart2js. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=24081

Patch Set 2 : Merged with HEAD #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -107 lines)			Patch
M	dart/runtime/lib/mirrors_impl.dart	View	1	10 chunks	+13 lines, -67 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	12 chunks	+56 lines, -40 lines	0 comments	Download
A	dart/tests/lib/mirrors/to_string_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/15679024/diff/1/dart/runtime/lib/mirrors_impl.dart File dart/runtime/lib/mirrors_impl.dart (left): https://codereview.chromium.org/15679024/diff/1/dart/runtime/lib/mirrors_impl.dart#oldcode254 dart/runtime/lib/mirrors_impl.dart:254: String _dartEscape(String str) { I have requested something like ...

7 years, 6 months ago (2013-06-12 16:27:26 UTC) #1

ahe

7 years, 6 months ago (2013-06-17 09:39:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24081 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15679024: Improve toString on mirrors and align VM and dart2js. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merged with HEAD #

Messages