Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 156763002: New analyzer snapshot. (Closed)

Created:
6 years, 10 months ago by scheglov
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

New analyzer snapshot. 1. Rename WorkManagerPriority -> SourcePriority. 2. Replace CharSequence with String. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32373

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -273 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 15 chunks +19 lines, -19 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/SourcePriority.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/WorkManagerPriority.java View 1 chunk +0 lines, -49 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 1 chunk +0 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 6 chunks +12 lines, -20 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 1 chunk +0 lines, -45 lines 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/example/scanner_driver.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/analyzer.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/error.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 21 chunks +61 lines, -61 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/formatter_impl.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/coverage_impl.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/string_source.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 7 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/test/services/formatter_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/services/test_utils.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/observe/lib/transformer.dart View 2 chunks +1 line, -2 lines 2 comments Download
M pkg/polymer/lib/src/build/code_extractor.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/script_compactor.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 10 months ago (2014-02-06 17:38:05 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-02-06 18:08:03 UTC) #2
scheglov
Committed patchset #1 manually as r32373 (presubmit successful).
6 years, 10 months ago (2014-02-06 18:09:35 UTC) #3
blois
https://codereview.chromium.org/156763002/diff/1/pkg/observe/lib/transformer.dart File pkg/observe/lib/transformer.dart (left): https://codereview.chromium.org/156763002/diff/1/pkg/observe/lib/transformer.dart#oldcode119 pkg/observe/lib/transformer.dart:119: var reader = new CharSequenceReader(new CharSequence(code)); Note that the ...
6 years, 10 months ago (2014-02-13 01:08:40 UTC) #4
Siggi Cherem (dart-lang)
6 years, 10 months ago (2014-02-13 01:25:21 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/156763002/diff/1/pkg/observe/lib/transformer....
File pkg/observe/lib/transformer.dart (left):

https://codereview.chromium.org/156763002/diff/1/pkg/observe/lib/transformer....
pkg/observe/lib/transformer.dart:119: var reader = new CharSequenceReader(new
CharSequence(code));
On 2014/02/13 01:08:41, blois wrote:
> Note that the pubspec.yaml for observe is still <0.12. Ditto for Polymer.

Good catch Pete. Yeah, this should bump up the version constraint on observe.
While this is not a breaking change for observe, the pubspec of should reflect
that it now depends on the new analyzer. Also note that because the next version
of observe will be used with the next version of polymer, we should make sure
that their dependencies are also consistent with each other (otherwise pub will
fail to find a solution).

Thinking more about this, probably every time we increase the version of a
package in the repo, we should consider updating the constraints on every
project that depends on it (and possibly repeat the process if we have to bump
the versions on those packages too).

Powered by Google App Engine
This is Rietveld 408576698