Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15675016: More fixes for java2dart and status files. (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More fixes for java2dart and status files. Now DDA passes/fails the same tests as Java version. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23705

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1199 lines, -563 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart View 1 chunk +2 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 1 chunk +5 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 1 chunk +9 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 4 chunks +23 lines, -10 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 5 chunks +5 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/bin/analyzer.dart View 1 chunk +23 lines, -25 lines 2 comments Download
M pkg/analyzer_experimental/lib/options.dart View 5 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/analyzer_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 5 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 45 chunks +121 lines, -80 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/instrumentation.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_engine.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_io.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 18 chunks +138 lines, -29 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/utilities_dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 4 chunks +32 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 29 chunks +169 lines, -131 lines 0 comments Download
M pkg/pkg.status View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +12 lines, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -272 lines 0 comments Download
A tests/language/language_analyzer.status View 1 chunk +276 lines, -0 lines 0 comments Download
A tests/language/language_analyzer2.status View 1 chunk +276 lines, -0 lines 0 comments Download
M tests/lib/analyzer/analyze_tests.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +15 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 6 months ago (2013-06-06 03:45:21 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/15675016/diff/1/pkg/analyzer_experimental/bin/analyzer.dart File pkg/analyzer_experimental/bin/analyzer.dart (right): https://codereview.chromium.org/15675016/diff/1/pkg/analyzer_experimental/bin/analyzer.dart#newcode61 pkg/analyzer_experimental/bin/analyzer.dart:61: // pring errors "pring" --> "print" https://codereview.chromium.org/15675016/diff/1/pkg/analyzer_experimental/bin/analyzer.dart#newcode62 pkg/analyzer_experimental/bin/analyzer.dart:62: ...
7 years, 6 months ago (2013-06-06 16:53:18 UTC) #2
scheglov
7 years, 6 months ago (2013-06-06 18:14:07 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r23705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698