Check how many Smi digits are acceptable when parsing integers.

Check how many Smi digits are acceptable when parsing integers.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23331

[siva, 2013-05-28 16:00:37]

lgtm

https://codereview.chromium.org/15670009/diff/1/runtime/lib/integers_patch.dart
File runtime/lib/integers_patch.dart (right):

https://codereview.chromium.org/15670009/diff/1/runtime/lib/integers_patch.da...
runtime/lib/integers_patch.dart:16: static bool is64Bit() => 4294967296 is _Smi;
maybe 4294967296 should be a static constant so that this code
is more readable.

I wondering if at some point we should have an internal private
class called _VM that can keep all these VM specific stuff.

[srdjan, 2013-05-29 09:04:09]

https://codereview.chromium.org/15670009/diff/1/runtime/lib/integers_patch.dart
File runtime/lib/integers_patch.dart (right):

https://codereview.chromium.org/15670009/diff/1/runtime/lib/integers_patch.da...
runtime/lib/integers_patch.dart:16: static bool is64Bit() => 4294967296 is _Smi;
On 2013/05/28 16:00:37, siva wrote:
> maybe 4294967296 should be a static constant so that this code
> is more readable.
> 

Changed to 1 << 32, so it should be clear. Let me know if you disagree and still
want a global constant.

> I wondering if at some point we should have an internal private
> class called _VM that can keep all these VM specific stuff.

I agree. Once we start sharing that test among various classes, we should  add
class _VM.

[srdjan, 2013-05-29 09:14:25]

Committed patchset #3 manually as r23331 (presubmit successful).