Issue 156633002: Change FileStat static methods to return NOT_FOUND instead for throwing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156633002: Change FileStat static methods to return NOT_FOUND instead for throwing (Closed)

Created:
6 years, 10 months ago by Søren Gjesse

Modified:
6 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change FileStat static methods to return NOT_FOUND instead for throwing R=ajohnsen@google.com BUG=http://dartbug.com/16558 Committed: https://code.google.com/p/dart/source/detail?r=32352

Patch Set 2 : Addressed review comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	sdk/lib/io/file_system_entity.dart	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download
	M	tests/standalone/io/file_stat_test.dart	View		2 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/156633002/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/156633002/diff/1/sdk/lib/io/file_system_entity.dart#newcode76 sdk/lib/io/file_system_entity.dart:76: this.size); newline

6 years, 10 months ago (2014-02-06 10:20:16 UTC) #2

Søren Gjesse

https://codereview.chromium.org/156633002/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/156633002/diff/1/sdk/lib/io/file_system_entity.dart#newcode76 sdk/lib/io/file_system_entity.dart:76: this.size); On 2014/02/06 10:20:16, Anders Johnsen wrote: > newline ...

6 years, 10 months ago (2014-02-06 11:27:27 UTC) #3

Søren Gjesse

6 years, 10 months ago (2014-02-06 11:27:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32352 (presubmit successful).

Expand Messages | Collapse Messages

Issue 156633002: Change FileStat static methods to return NOT_FOUND instead for throwing (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages