Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 15660010: Fixing dart2js compilation warning. (Closed)

Created:
7 years, 6 months ago by blois
Modified:
7 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing dart2js compilation warning. Was seeing the warnings: build/ReleaseIA32/dart-sdk/lib/html/dart2js/html_dart2js.dart:15831:21: Warning: no property named _this in class Iterable if (identical(newNodes._this, this)) { ^^^^^^^^^^^^^^ build/ReleaseIA32/dart-sdk/lib/html/dart2js/html_dart2js.dart:15838:27: Warning: no operator [] in class Iterable this.insertBefore(newNodes[0], refChild); BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=23428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 6 months ago (2013-05-30 17:39:10 UTC) #1
Emily Fortuna
lgtm
7 years, 6 months ago (2013-05-30 17:41:15 UTC) #2
blois
7 years, 6 months ago (2013-05-30 17:47:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698