Issue 15649021: Simplified the killing mechanism in browser_controller.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15649021: Simplified the killing mechanism in browser_controller.dart (Closed)

Created:
7 years, 6 months ago by kustermann

Modified:
7 years, 6 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplified the killing mechanism in browser_controller.dart R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23674

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -69 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View	1 2	2 chunks	+26 lines, -69 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/15649021/diff/2001/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/15649021/diff/2001/tools/testing/dart/browser_controller.dart#newcode99 tools/testing/dart/browser_controller.dart:99: Future _killIt() { remove this function and just ...

7 years, 6 months ago (2013-06-06 11:07:46 UTC) #2

kustermann

https://codereview.chromium.org/15649021/diff/2001/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/15649021/diff/2001/tools/testing/dart/browser_controller.dart#newcode99 tools/testing/dart/browser_controller.dart:99: Future _killIt() { On 2013/06/06 11:07:46, ricow1 wrote: > ...

7 years, 6 months ago (2013-06-06 11:12:22 UTC) #3

kustermann

7 years, 6 months ago (2013-06-06 11:13:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r23674 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15649021: Simplified the killing mechanism in browser_controller.dart (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages