Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 15647019: Regression test for issue 11023 (Closed)

Created:
7 years, 6 months ago by hausner
Modified:
7 years, 6 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, regis
Visibility:
Public.

Description

Regression test for issue 11023 The VM resolves types too eagerly at least during top-level parsing. This may result in referencing the wrong type, as in this new test. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23651

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A tests/language/extends_test.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download
A tests/language/extends_test_lib.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 6 months ago (2013-06-05 18:26:17 UTC) #1
Ivan Posva
LGTM with comment. -Ivan https://codereview.chromium.org/15647019/diff/1/tests/language/extends_test.dart File tests/language/extends_test.dart (right): https://codereview.chromium.org/15647019/diff/1/tests/language/extends_test.dart#newcode19 tests/language/extends_test.dart:19: s.y = 10; How about ...
7 years, 6 months ago (2013-06-05 18:31:34 UTC) #2
hausner
https://codereview.chromium.org/15647019/diff/1/tests/language/extends_test.dart File tests/language/extends_test.dart (right): https://codereview.chromium.org/15647019/diff/1/tests/language/extends_test.dart#newcode19 tests/language/extends_test.dart:19: s.y = 10; On 2013/06/05 18:31:34, Ivan Posva wrote: ...
7 years, 6 months ago (2013-06-05 18:37:54 UTC) #3
hausner
7 years, 6 months ago (2013-06-05 19:15:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698