Make dartdoc.bat work with snapshots and run in the repo.

Make dartdoc.bat work with snapshots and run in the repo.

This supercedes https://codereview.chromium.org/16415003/.

BUG=
R=dgrove@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23722

[Bob Nystrom, 2013-06-06 21:44:44]

This gets bin/dartdoc.bat in a happier place.

If you run it from the repo, it runs dartdoc directly from
sdk/lib/_internal/dartdoc. If you run it from the built SDK, it uses the
snapshot.

It has one minor issue that I can't figure out: if you run it from the repo, the
batch file prints out "The system cannot find the drive specified." I can't
figure out why, or even exactly which line of the script causes this.

Sending this out now, because it's at least an improvement. In the built SDK, it
seems to work fine.

[dgrove, 2013-06-06 22:17:42]

https://codereview.chromium.org/15645010/diff/1/sdk/bin/dartdoc.bat
File sdk/bin/dartdoc.bat (right):

https://codereview.chromium.org/15645010/diff/1/sdk/bin/dartdoc.bat#newcode28
sdk/bin/dartdoc.bat:28: "%DART%" "%SNAPSHOT%" "dartdoc" %*
In the existing sdk/bin/dartdoc, it passes in --library-root . Not sure if you
want this. It also passes in --package-root.

[Bob Nystrom, 2013-06-06 22:27:55]

https://codereview.chromium.org/15645010/diff/1/sdk/bin/dartdoc.bat
File sdk/bin/dartdoc.bat (right):

https://codereview.chromium.org/15645010/diff/1/sdk/bin/dartdoc.bat#newcode28
sdk/bin/dartdoc.bat:28: "%DART%" "%SNAPSHOT%" "dartdoc" %*
On 2013/06/06 22:17:42, dgrove wrote:
> In the existing sdk/bin/dartdoc, it passes in --library-root . Not sure if you
> want this. It also passes in --package-root.

I'm not sure if those are something the script can provide or not. It's passing
in --package-root twice: once for Dart and once for Dartdoc. We definitely don't
need the former since it's running from a snapshot.

I don't think the latter is correct either: users should be using their app's
packages directory and not the SDK's. I'm not sure about --library-root. :(

[dgrove, 2013-06-06 22:29:31]

On 2013/06/06 22:27:55, Bob Nystrom wrote:
> https://codereview.chromium.org/15645010/diff/1/sdk/bin/dartdoc.bat
> File sdk/bin/dartdoc.bat (right):
> 
> https://codereview.chromium.org/15645010/diff/1/sdk/bin/dartdoc.bat#newcode28
> sdk/bin/dartdoc.bat:28: "%DART%" "%SNAPSHOT%" "dartdoc" %*
> On 2013/06/06 22:17:42, dgrove wrote:
> > In the existing sdk/bin/dartdoc, it passes in --library-root . Not sure if
you
> > want this. It also passes in --package-root.
> 
> I'm not sure if those are something the script can provide or not. It's
passing
> in --package-root twice: once for Dart and once for Dartdoc. We definitely
don't
> need the former since it's running from a snapshot.
> 
> I don't think the latter is correct either: users should be using their app's
> packages directory and not the SDK's. I'm not sure about --library-root. :(

I think this is fine, then.

[dgrove, 2013-06-06 22:29:37]

lgtm

[Bob Nystrom, 2013-06-06 22:54:37]

Committed patchset #1 manually as r23722 (presubmit successful).