Issue 15643008: Bugfix in test_runner.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15643008: Bugfix in test_runner.dart (Closed)

Created:
7 years, 6 months ago by kustermann

Modified:
7 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bugfix in test_runner.dart On MacOS the content shell executable name included "-characters. Since we're not running the command in a shell, these characters are part of the filename and the exec syscall will fail. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=23463

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, Thank you! Perhaps you could be a little more specific in the CL description.

7 years, 6 months ago (2013-05-31 12:07:05 UTC) #2

kustermann

7 years, 6 months ago (2013-05-31 12:19:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23463 (presubmit successful).

Expand Messages | Collapse Messages