Issue 15643004: Fix breakages from r23266

Issue 15643004: Fix breakages from r23266 (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix breakages from r23266 TBR=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23270 Committed: https://code.google.com/p/dart/source/detail?r=23283

Patch Set 2 : Addressed review comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/compiler/dart2js/mirrors_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	utils/apidoc/html_diff.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r23270 (presubmit successful).

7 years, 6 months ago (2013-05-28 13:51:52 UTC) #2

floitsch

LGTM with comment. https://codereview.chromium.org/15643004/diff/1/tests/compiler/dart2js/mirrors_metadata_test.dart File tests/compiler/dart2js/mirrors_metadata_test.dart (right): https://codereview.chromium.org/15643004/diff/1/tests/compiler/dart2js/mirrors_metadata_test.dart#newcode15 tests/compiler/dart2js/mirrors_metadata_test.dart:15: Uri SOURCE_URI = new Uri(scheme: SOURCE, ...

7 years, 6 months ago (2013-05-28 14:50:40 UTC) #3

Søren Gjesse

https://codereview.chromium.org/15643004/diff/1/tests/compiler/dart2js/mirrors_metadata_test.dart File tests/compiler/dart2js/mirrors_metadata_test.dart (right): https://codereview.chromium.org/15643004/diff/1/tests/compiler/dart2js/mirrors_metadata_test.dart#newcode15 tests/compiler/dart2js/mirrors_metadata_test.dart:15: Uri SOURCE_URI = new Uri(scheme: SOURCE, path: SOURCE); On ...

7 years, 6 months ago (2013-05-28 15:15:55 UTC) #4

Søren Gjesse

7 years, 6 months ago (2013-05-28 15:16:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23283 (presubmit successful).

Expand Messages | Collapse Messages