Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 15640002: Fix runnning of vm benchmarks on golem. (Closed)

Created:
7 years, 7 months ago by siva
Modified:
7 years, 7 months ago
Reviewers:
Anders Johnsen, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix runnning of vm benchmarks on golem. Use snapshots for creating isolates used in the benchmarks, that way they are not dependent on corelib source paths. R=ajohnsen@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=23023

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -41 lines) Patch
M runtime/bin/bin.gypi View 1 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/benchmark_test.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 19 chunks +56 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
7 years, 7 months ago (2013-05-22 02:13:28 UTC) #1
Anders Johnsen
LGTM (kind of rubberstamp). https://codereview.chromium.org/15640002/diff/1/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/15640002/diff/1/runtime/vm/raw_object_snapshot.cc#newcode576 runtime/vm/raw_object_snapshot.cc:576: ASSERT(kind != Snapshot::kMessage); This assertion ...
7 years, 7 months ago (2013-05-22 05:51:38 UTC) #2
siva
https://codereview.chromium.org/15640002/diff/1/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/15640002/diff/1/runtime/vm/raw_object_snapshot.cc#newcode576 runtime/vm/raw_object_snapshot.cc:576: ASSERT(kind != Snapshot::kMessage); Good point. Removed that assertion. On ...
7 years, 7 months ago (2013-05-22 15:45:12 UTC) #3
srdjan
lgtm
7 years, 7 months ago (2013-05-22 16:05:45 UTC) #4
siva
7 years, 7 months ago (2013-05-22 16:07:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r23023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698