Chromium Code Reviews

Issue 15621002: Allow passing in an existing ArgParser for a command. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow passing in an existing ArgParser for a command. R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=22973

Patch Set 1 #

Total comments: 2

Patch Set 2 : More docs. #

Unified diffs Side-by-side diffs Stats (+57 lines, -11 lines)
M pkg/args/lib/args.dart View 2 chunks +42 lines, -11 lines 0 comments
M pkg/args/test/command_test.dart View 1 chunk +15 lines, -0 lines 0 comments

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I'm working on making pub use the args package's command support and this will help.
7 years, 7 months ago (2013-05-21 22:43:39 UTC) #1
gram
The specific change lgtm but the feature needs more explanation. https://codereview.chromium.org/15621002/diff/1/pkg/args/lib/args.dart File pkg/args/lib/args.dart (right): https://codereview.chromium.org/15621002/diff/1/pkg/args/lib/args.dart#newcode185 ...
7 years, 7 months ago (2013-05-21 23:11:07 UTC) #2
Bob Nystrom
https://codereview.chromium.org/15621002/diff/1/pkg/args/lib/args.dart File pkg/args/lib/args.dart (right): https://codereview.chromium.org/15621002/diff/1/pkg/args/lib/args.dart#newcode185 pkg/args/lib/args.dart:185: * entered and what options were provided for it. ...
7 years, 7 months ago (2013-05-21 23:20:15 UTC) #3
Bob Nystrom
7 years, 7 months ago (2013-05-21 23:20:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22973 (presubmit successful).

Powered by Google App Engine