Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1561323002: Add CancelableOperation.valueOrCancellation. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -7 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -1 line 0 comments Download
M lib/src/cancelable_operation.dart View 1 2 chunks +26 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/cancelable_operation_test.dart View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 11 months ago (2016-01-06 22:35:03 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1561323002/diff/1/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1561323002/diff/1/lib/src/cancelable_operation.dart#newcode61 lib/src/cancelable_operation.dart:61: /// it's cancelled. I'm a little concerned about ...
4 years, 11 months ago (2016-01-07 07:20:53 UTC) #2
nweiz
Code review changes
4 years, 11 months ago (2016-01-07 20:12:41 UTC) #3
nweiz
https://codereview.chromium.org/1561323002/diff/1/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1561323002/diff/1/lib/src/cancelable_operation.dart#newcode61 lib/src/cancelable_operation.dart:61: /// it's cancelled. On 2016/01/07 07:20:53, Lasse Reichstein Nielsen ...
4 years, 11 months ago (2016-01-07 20:14:31 UTC) #4
nweiz
4 years, 11 months ago (2016-01-07 20:16:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c40f7dc094062c7d7ac0636804405596d7f9e7e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698