Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1561073003: Support re-running tests while debugging. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@debugger-wip
Target Ref:
refs/heads/debugger-wip
Visibility:
Public.

Description

Support re-running tests while debugging. When the browser is paused at a breakpoint, the runner will now open a command-line console with a "restart" command that will restart the current test. This currently has no tests, due to dart-lang/sdk#25369 and the lack of a programmatic API for interacting with Observatory. I've tested it reasonably thoroughly by hand, but it's more likely than the average feature to have lurking bugs. Closes #335 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/2dfe0f9ebbfe9334d7d5cdf788eb93f2fd7358f5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -119 lines) Patch
M CHANGELOG.md View 1 2 chunks +12 lines, -0 lines 0 comments Download
M lib/src/backend/live_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/runner.dart View 6 chunks +10 lines, -72 lines 0 comments Download
M lib/src/runner/browser/iframe_test.dart View 2 chunks +20 lines, -5 lines 0 comments Download
A lib/src/runner/console.dart View 1 chunk +120 lines, -0 lines 0 comments Download
M lib/src/runner/debugger.dart View 2 chunks +126 lines, -34 lines 0 comments Download
M lib/src/runner/engine.dart View 2 chunks +29 lines, -0 lines 0 comments Download
M lib/src/runner/loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/reporter/compact.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
4 years, 11 months ago (2016-01-07 02:54:24 UTC) #1
kevmoo
One comment – this is complex stuff. The initial pass looks good. I couldn't apply ...
4 years, 11 months ago (2016-01-07 21:34:00 UTC) #2
nweiz
Code review changes
4 years, 11 months ago (2016-01-07 21:38:59 UTC) #3
nweiz
I've updated the async dependency to use the public git repo, so you should be ...
4 years, 11 months ago (2016-01-07 21:47:40 UTC) #4
nweiz
Committed patchset #2 (id:20001) manually as 2dfe0f9ebbfe9334d7d5cdf788eb93f2fd7358f5 (presubmit successful).
4 years, 11 months ago (2016-01-07 21:47:49 UTC) #6
kevmoo
4 years, 11 months ago (2016-01-08 18:26:41 UTC) #7
Message was sent while issue was closed.
On 2016/01/07 21:47:49, nweiz wrote:
> Committed patchset #2 (id:20001) manually as
> 2dfe0f9ebbfe9334d7d5cdf788eb93f2fd7358f5 (presubmit successful).

It appears this commit went into your working branch? debugger-wip?

Powered by Google App Engine
This is Rietveld 408576698