Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1560393002: Fix a failing test on Windows. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a failing test on Windows. Pub wasn't canonicalizing a path in the same way as the tests, which caused a difference on the Windows bots. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/a7dc86cf8ba49711facdce29525dcf8c6db2b9bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/pubspec.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 11 months ago (2016-01-06 01:52:58 UTC) #1
Bob Nystrom
lgtm
4 years, 11 months ago (2016-01-06 17:06:42 UTC) #2
nweiz
4 years, 11 months ago (2016-01-06 21:22:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7dc86cf8ba49711facdce29525dcf8c6db2b9bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698