Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 156033002: Fix to ensure no breaks after new and general zero-length space support (dartbug.com/16379). (Closed)

Created:
6 years, 10 months ago by pquitslund
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix to ensure no breaks after new and general zero-length space support (dartbug.com/16379). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32332

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 5 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/writer.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/services/data/stmt_tests.data View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 10 months ago (2014-02-05 18:12:15 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-02-05 18:37:49 UTC) #2
pquitslund
6 years, 10 months ago (2014-02-05 18:41:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698