Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1557253002: Fix lock_file_test. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix lock_file_test. This got broken when the "sdk" field was added. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/eba57ad1709fd7fc0282239a504f5136d3ca898b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/lock_file_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 11 months ago (2016-01-05 01:58:59 UTC) #1
Bob Nystrom
lgtm
4 years, 11 months ago (2016-01-05 17:15:21 UTC) #2
nweiz
4 years, 11 months ago (2016-01-05 21:40:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eba57ad1709fd7fc0282239a504f5136d3ca898b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698