Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 155703004: Support parameter metadata. (Closed)

Created:
6 years, 10 months ago by Johnni Winther
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Support parameter metadata. BUG=http://dartbug.com/15820 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32413

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -33 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/utils.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 3 chunks +22 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 3 chunks +17 lines, -3 lines 1 comment Download
M sdk/lib/_internal/compiler/implementation/resolution/resolution.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/signatures.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 6 chunks +28 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 2 chunks +6 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 6 chunks +38 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/prettyprint.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/unparser.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mirrors_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 4 chunks +15 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
This only supports parameter metadata in the front end.
6 years, 10 months ago (2014-02-05 11:18:19 UTC) #1
floitsch
and LGTM. https://codereview.chromium.org/155703004/diff/20001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/155703004/diff/20001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3010 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3010: addDeferredAction(variables, () { why do we need ...
6 years, 10 months ago (2014-02-06 23:09:45 UTC) #2
Johnni Winther
6 years, 10 months ago (2014-02-07 08:48:01 UTC) #3
Johnni Winther
6 years, 10 months ago (2014-02-07 08:56:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r32413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698