Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1556243002: Fix analyzer hints and warnings in test/. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -136 lines) Patch
M test/ascii_tree_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/barback/fails_if_args_with_all_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/barback/fails_if_dir_outside_package_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/barback/fails_if_no_default_dirs_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/barback/fails_on_all_with_no_buildable_directories_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/barback/fails_on_disallowed_directories_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/cache/repair/handles_corrupted_binstub_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/recompiles_snapshots_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/descriptor.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/global/activate/activate_hosted_after_git_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M test/global/activate/outdated_binstub_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M test/global/binstubs/binstub_runs_executable_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/global/binstubs/does_not_warn_if_no_executables_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/global/binstubs/no_executables_flag_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/global/binstubs/outdated_binstub_runs_pub_global_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/global/binstubs/outdated_snapshot_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/global/binstubs/removes_even_if_not_in_pubspec_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/global/binstubs/removes_when_deactivated_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/global/run/errors_if_outside_bin_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/global/run/implicit_executable_name_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/global/run/runs_script_in_unchecked_mode_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/io_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/lock_file_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M test/must_pub_get_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/preprocess_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/pub_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/run/doesnt_load_an_unnecessary_transformer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/run/forwards_signal_posix_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M test/run/resource_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/run/runs_from_a_dependency_override_after_dependency_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/serve/native_watch_replaced_file_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/serve/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/serve_packages.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/doesnt_snapshot_an_entrypoint_dependency_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/snapshot/doesnt_snapshot_path_dependency_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/test_pub.dart View 6 chunks +4 lines, -20 lines 0 comments Download
M test/transcript_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/cache_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/configuration/configuration_defaults_to_empty_map_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/transformer/configuration/passes_configuration_to_a_transformer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/transformer/configuration/with_configuration_only_instantiates_configurable_transformers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/utils_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/validator/pubspec_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/validator/sdk_constraint_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M test/version_solver_test.dart View 3 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 11 months ago (2016-01-05 01:55:33 UTC) #1
Bob Nystrom
lgtm
4 years, 11 months ago (2016-01-05 17:14:57 UTC) #2
nweiz
4 years, 11 months ago (2016-01-05 21:36:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1a769e1d3c4596a6834035f94817a43e1b5c1f52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698