Issue 155593004: Another adjustment to constant_map to fix analyzer warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155593004: Another adjustment to constant_map to fix analyzer warnings. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Another adjustment to constant_map to fix analyzer warnings. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=32448

Patch Set 1 : #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/_internal/lib/constant_map.dart	View		2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Two other small tweaks to this file -- I missed the other warnings because they ...

6 years, 10 months ago (2014-02-07 02:03:50 UTC) #1

sra1

lgtm lgtm. I think I did these on a PTAL on my reference CL. https://codereview.chromium.org/155593004/diff/30001/sdk/lib/_internal/lib/constant_map.dart ...

6 years, 10 months ago (2014-02-07 02:24:45 UTC) #2

Emily Fortuna

6 years, 10 months ago (2014-02-07 20:30:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32448 (presubmit successful).

Expand Messages | Collapse Messages