Add 'start' and 'end' optional arguments to File.openRead(). This makes it possible to stream a sub…

Add 'start' and 'end' optional arguments to File.openRead(). This makes it possible to stream a sub-range of a file.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22922

[Søren Gjesse, 2013-05-21 09:06:04]

lgtm

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart
File sdk/lib/io/file.dart (right):

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart#newcode183
sdk/lib/io/file.dart:183: * Create a new independent
[Stream](../dart_async/Stream.html) for the
Remove the reference ../dart_async/Stream.html.

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart#newcode185
sdk/lib/io/file.dart:185: *
Move this part below the description of the arguments.

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart#newcode190
sdk/lib/io/file.dart:190: * If [start] is present, the file will be read from
byte-offset [start].
add (index 0) after beginning.

https://codereview.chromium.org/15547003/diff/1/tests/standalone/io/file_inpu...
File tests/standalone/io/file_input_stream_test.dart (right):

https://codereview.chromium.org/15547003/diff/1/tests/standalone/io/file_inpu...
tests/standalone/io/file_input_stream_test.dart:175: var temp = new
Directory('').createTempSync();
Change the name of the test-file to match the test.

https://codereview.chromium.org/15547003/diff/1/tests/standalone/io/file_inpu...
tests/standalone/io/file_input_stream_test.dart:206: var temp = new
Directory('').createTempSync();
Change the name of the test-file to match the test.

[Anders Johnsen, 2013-05-21 09:22:11]

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart
File sdk/lib/io/file.dart (right):

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart#newcode183
sdk/lib/io/file.dart:183: * Create a new independent
[Stream](../dart_async/Stream.html) for the
On 2013/05/21 09:06:04, Søren Gjesse wrote:
> Remove the reference ../dart_async/Stream.html.

Done.

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart#newcode185
sdk/lib/io/file.dart:185: *
On 2013/05/21 09:06:04, Søren Gjesse wrote:
> Move this part below the description of the arguments.

Done.

https://codereview.chromium.org/15547003/diff/1/sdk/lib/io/file.dart#newcode190
sdk/lib/io/file.dart:190: * If [start] is present, the file will be read from
byte-offset [start].
On 2013/05/21 09:06:04, Søren Gjesse wrote:
> add (index 0) after beginning.

Done.

https://codereview.chromium.org/15547003/diff/1/tests/standalone/io/file_inpu...
File tests/standalone/io/file_input_stream_test.dart (right):

https://codereview.chromium.org/15547003/diff/1/tests/standalone/io/file_inpu...
tests/standalone/io/file_input_stream_test.dart:175: var temp = new
Directory('').createTempSync();
On 2013/05/21 09:06:04, Søren Gjesse wrote:
> Change the name of the test-file to match the test.

Done.

https://codereview.chromium.org/15547003/diff/1/tests/standalone/io/file_inpu...
tests/standalone/io/file_input_stream_test.dart:206: var temp = new
Directory('').createTempSync();
On 2013/05/21 09:06:04, Søren Gjesse wrote:
> Change the name of the test-file to match the test.

Done.

[Anders Johnsen, 2013-05-21 09:22:33]

Committed patchset #2 manually as r22922 (presubmit successful).