Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 155393002: Replace dead instructions with a constant with no type (Closed)

Created:
6 years, 10 months ago by sra1
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace dead instructions with a constant with no type Previously the dead instructions were replaced with int 0, which polluted the types. There are only occasional improvements since most optimizations happen before the first dead code elimination phase. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32876

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sra1
This change fixes the union type I was seeing. Not sure if it is worth ...
6 years, 10 months ago (2014-02-05 01:12:48 UTC) #1
sra1
This change fixes the union type I was seeing. Not sure if it is worth ...
6 years, 10 months ago (2014-02-05 01:12:49 UTC) #2
floitsch
The names are off, but otherwise LGTM. Maybe just renaming DummyReceiverConstant to DummyConstant ?
6 years, 10 months ago (2014-02-06 23:15:42 UTC) #3
sra1
Committed patchset #1 manually as r32876 (presubmit successful).
6 years, 10 months ago (2014-02-20 23:51:03 UTC) #4
floitsch
You ignored my comment. Why do you prefer keeping the current DummyReceiverConstant name?
6 years, 10 months ago (2014-02-21 09:59:07 UTC) #5
sra1
On 2014/02/21 09:59:07, floitsch wrote: > You ignored my comment. > Why do you prefer ...
6 years, 10 months ago (2014-02-21 20:16:19 UTC) #6
floitsch
6 years, 10 months ago (2014-02-22 21:00:14 UTC) #7
Message was sent while issue was closed.
On 2014/02/21 20:16:19, sra1 wrote:
> On 2014/02/21 09:59:07, floitsch wrote:
> > You ignored my comment.
> > Why do you prefer keeping the current DummyReceiverConstant name?
> 
> The renaming is a much bigger change that would hide the real change.
> https://codereview.chromium.org/172853007/

Ok. I was afraid you hadn't seen my comment (seeing my green name in the
review-view).
Should have expressed myself differently.

Powered by Google App Engine
This is Rietveld 408576698