Let debug target pick the debugger port

Let debug target pick the debugger port

Invoking the dart executable with --debug:0 lets the debuggee pick a free port number. It prints the port number to stdout if --verbose_debug is specified on the command line.

Adapt debugger tests to use this scheme for selecting an available port number.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23086

[hausner, 2013-05-22 22:42:58]

Ping.

[Ivan Posva, 2013-05-23 02:06:11]

LGTM -ip

https://codereview.chromium.org/15507004/diff/12001/tests/standalone/debugger...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/15507004/diff/12001/tests/standalone/debugger...
tests/standalone/debugger/debug_lib.dart:314: stdin.listen((_) {});
Why is this stdin even needed? This is the stdin of the XYZ_debugger_test.dart,
which we should not be messing with at all in this case, correct?

[Ivan Posva, 2013-05-23 02:25:54]

Matthias,

Apparently these tests were disabled. Please reenable them again while landing
this CL.

Thanks,
-Ivan

[kustermann, 2013-05-23 07:22:32]

https://codereview.chromium.org/15507004/diff/12001/tests/standalone/debugger...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/15507004/diff/12001/tests/standalone/debugger...
tests/standalone/debugger/debug_lib.dart:314: stdin.listen((_) {});
On 2013/05/23 02:06:11, Ivan Posva wrote:
> Why is this stdin even needed? This is the stdin of the
XYZ_debugger_test.dart,
> which we should not be messing with at all in this case, correct?

Correct, this should not be necessary.
When have had problems with this before when I filed http://dartbug.com/9439.

[hausner, 2013-05-23 17:41:40]

https://codereview.chromium.org/15507004/diff/12001/tests/standalone/debugger...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/15507004/diff/12001/tests/standalone/debugger...
tests/standalone/debugger/debug_lib.dart:314: stdin.listen((_) {});
Removed this line.

On 2013/05/23 07:22:32, kustermann wrote:
> On 2013/05/23 02:06:11, Ivan Posva wrote:
> > Why is this stdin even needed? This is the stdin of the
> XYZ_debugger_test.dart,
> > which we should not be messing with at all in this case, correct?
> 
> Correct, this should not be necessary.
> When have had problems with this before when I filed http://dartbug.com/9439.

[hausner, 2013-05-23 17:41:54]

Committed patchset #4 manually as r23086 (presubmit successful).