Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 15496005: Fix some of the negative language tests in preparation for implementing (Closed)

Created:
7 years, 7 months ago by siva
Modified:
7 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some of the negative language tests in preparation for implementing delayed class parsing in Dart VM. - Some of the tests under tests/language expect compile-time errors but these tests do not use the class which has errors. When the VM will implement delayed parsing of classes (classes are parsed only if they are used) these tests will fail as the Dart VM will not report these as compile-time errors. The option VMOptions=--compile_all has been added to these tests to ensure that all classes are compiled and the error is reported. - One co19 test has a similar issue and a bug has been filed against it (co19 issue 415). the co19-runtime.status file has been updated to skip this test until issue 415 is resolved. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23113

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tests/co19/co19-runtime.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/external_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/field1_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/field2_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/field4_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/field5_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/field6_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/field6a_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/get_set_syntax_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/interface_static_method_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/non_const_super_negative_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/syntax_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 7 months ago (2013-05-20 23:10:00 UTC) #1
siva
7 years, 7 months ago (2013-05-20 23:10:35 UTC) #2
Ivan Posva
LGTM -ip
7 years, 7 months ago (2013-05-23 22:34:51 UTC) #3
siva
7 years, 7 months ago (2013-05-23 23:39:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698