Split out unittest tests whose behavior differs in minified mode.

Split out unittest tests whose behavior differs in minified mode.

R=gram@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22910

[gram, 2013-05-20 22:35:58]

lgtm with a couple of suggestions.

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/pretty_prin...
File pkg/unittest/test/pretty_print_minified_test.dart (right):

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/pretty_prin...
pkg/unittest/test/pretty_print_minified_test.dart:17: class CustomToString {
Perhaps refactor some of this common stuff like you did with the other tests, as
it is duplicated in minified and non-minified.

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/test_utils....
File pkg/unittest/test/test_utils.dart (right):

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/test_utils....
pkg/unittest/test/test_utils.dart:85: class Widget {
Can you move everything from Widget down into a file other than utils, say,
'test_common.dart'? Utils is really meant for general test support, not stuff
used by specific tests.

[nweiz, 2013-05-20 23:29:06]

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/pretty_prin...
File pkg/unittest/test/pretty_print_minified_test.dart (right):

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/pretty_prin...
pkg/unittest/test/pretty_print_minified_test.dart:17: class CustomToString {
On 2013/05/20 22:35:58, gram wrote:
> Perhaps refactor some of this common stuff like you did with the other tests,
as
> it is duplicated in minified and non-minified.

I thought about doing that when I wrote this, but since two of the classes need
to have private names it didn't seen worth the effort.

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/test_utils....
File pkg/unittest/test/test_utils.dart (right):

https://codereview.chromium.org/15492003/diff/1/pkg/unittest/test/test_utils....
pkg/unittest/test/test_utils.dart:85: class Widget {
On 2013/05/20 22:35:58, gram wrote:
> Can you move everything from Widget down into a file other than utils, say,
> 'test_common.dart'? Utils is really meant for general test support, not stuff
> used by specific tests.

Done.

[nweiz, 2013-05-20 23:30:47]

Committed patchset #2 manually as r22910 (presubmit successful).