Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 154733002: Fix disassembler crash with profiler (Closed)

Created:
6 years, 10 months ago by Cutch
Modified:
6 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix disassembler crash with profiler BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=32322

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 4 chunks +24 lines, -6 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
6 years, 10 months ago (2014-02-04 22:17:34 UTC) #1
Florian Schneider
lgtm
6 years, 10 months ago (2014-02-05 10:39:56 UTC) #2
Cutch
6 years, 10 months ago (2014-02-05 15:30:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698