Issue 15470013: Remove the IC data array from the isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15470013: Remove the IC data array from the isolate. (Closed)

Created:
7 years, 7 months ago by Kevin Millikin (Google)

Modified:
7 years, 7 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove the IC data array from the isolate. Thread it as an argument rather than storing it in a global variable. This means the programmer does not have to implement a shadow stack to save and restore the data array, and there is no special handling needed for GC. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22982

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -61 lines)			Patch
M	runtime/vm/compiler.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	14 chunks	+33 lines, -14 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	5 chunks	+3 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	4 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	3 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

7 years, 7 months ago (2013-05-22 06:22:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22982 (presubmit successful).

Expand Messages | Collapse Messages