Issue 15444003: Use args' command support for pub commands.

Issue 15444003: Use args' command support for pub commands. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom

Modified:
7 years, 7 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use args' command support for pub commands. Cleans up pub a bit and in particular lets you do: $ pub install --verbose R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=23035

Patch Set 1 #

Patch Set 2 : Allow --help after command to get command help. #

Total comments: 6

Patch Set 3 : Initialize command args in constructor. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -120 lines)			Patch
M	sdk/lib/_internal/pub/bin/pub.dart	View		2 chunks	+53 lines, -42 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command.dart	View	1 2	4 chunks	+39 lines, -33 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command_install.dart	View	1 2	1 chunk	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command_lish.dart	View	1 2	3 chunks	+10 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command_update.dart	View	1 2	1 chunk	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command_uploader.dart	View	1 2	2 chunks	+9 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/hosted_source.dart	View	1	5 chunks	+8 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/pub_cache_test.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/pub_test.dart	View	1	4 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nweiz

Does "pub install --help" display the documentation for "pub install" or for "pub"? It should ...

7 years, 7 months ago (2013-05-22 00:16:45 UTC) #2

kevmoo-old

I'm a fan of pub help install (What I do in hop) `help` is a ...

7 years, 7 months ago (2013-05-22 01:44:50 UTC) #3

Bob Nystrom

On 2013/05/22 00:16:45, nweiz wrote: > Does "pub install --help" display the documentation for "pub ...

7 years, 7 months ago (2013-05-22 17:29:18 UTC) #4

nweiz

A couple suggestions, otherwise LGTM. https://codereview.chromium.org/15444003/diff/5001/sdk/lib/_internal/pub/lib/src/command.dart File sdk/lib/_internal/pub/lib/src/command.dart (right): https://codereview.chromium.org/15444003/diff/5001/sdk/lib/_internal/pub/lib/src/command.dart#newcode55 sdk/lib/_internal/pub/lib/src/command.dart:55: ArgParser commandParser; Can't you ...

7 years, 7 months ago (2013-05-22 18:11:52 UTC) #5

Bob Nystrom

Thanks! https://codereview.chromium.org/15444003/diff/5001/sdk/lib/_internal/pub/lib/src/command.dart File sdk/lib/_internal/pub/lib/src/command.dart (right): https://codereview.chromium.org/15444003/diff/5001/sdk/lib/_internal/pub/lib/src/command.dart#newcode55 sdk/lib/_internal/pub/lib/src/command.dart:55: ArgParser commandParser; On 2013/05/22 18:11:52, nweiz wrote: > ...

7 years, 7 months ago (2013-05-22 18:28:48 UTC) #6

Bob Nystrom

7 years, 7 months ago (2013-05-22 18:28:50 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r23035 (presubmit successful).

Expand Messages | Collapse Messages