Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 154403006: Properly handle top-levled errors in scheduled_test. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Properly handle top-levled errors in scheduled_test. R=rnystrom@google.com, alanknight@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32338

Patch Set 1 #

Patch Set 2 : small change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M pkg/scheduled_test/lib/scheduled_test.dart View 1 1 chunk +9 lines, -10 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/unhandled_error_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 10 months ago (2014-02-05 00:45:12 UTC) #1
Bob Nystrom
lgtm
6 years, 10 months ago (2014-02-05 20:48:45 UTC) #2
nweiz
6 years, 10 months ago (2014-02-05 21:22:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698