Issue 154353002: Fix for issue 16497 - fix load elimination aliasing for typed arrays

Issue 154353002: Fix for issue 16497 - fix load elimination aliasing for typed arrays (Closed)

Created:
6 years, 10 months ago by sra1

Modified:
6 years, 10 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for issue 16497 - fix load elimination aliasing for typed arrays R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32300

Patch Set 2 : #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	1 chunk	+6 lines, -4 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		3 chunks	+22 lines, -6 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://codereview.chromium.org/154353002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/154353002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1743 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1743: return compiler.typedDataClass != null New line after the ...

6 years, 10 months ago (2014-02-04 22:13:51 UTC) #2

sra1

Committed patchset #2 manually as r32300 (presubmit successful).

6 years, 10 months ago (2014-02-04 23:06:23 UTC) #3

ngeoffray

LGTM! https://codereview.chromium.org/154353002/diff/50001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/154353002/diff/50001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1741 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1741: bool intersects(TypeMask type1, TypeMask type2) => What is ...

6 years, 10 months ago (2014-02-05 09:25:52 UTC) #4

sra1

6 years, 10 months ago (2014-02-05 21:32:17 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/154353002/diff/50001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/154353002/diff/50001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1741: bool
intersects(TypeMask type1, TypeMask type2) =>
On 2014/02/05 09:25:53, ngeoffray wrote:
> What is it that the previous implementation did not cover?

containsMask is a subtype test.
The inputs might not satisfy a subtype possibly be a typed array.
The example I saw was  union(NativeInt16List, JSUInt31).
The union type is not a subtype of JSIndexingBehavior, but still could be a
typed array.

If you wonder where that weird type comes from, look at:
https://codereview.chromium.org/155393002/

Expand Messages | Collapse Messages