Issue 15404006: Fix svg_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15404006: Fix svg_test (Closed)

Created:
7 years, 7 months ago by vsm

Modified:
7 years, 7 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix svg_test This broke on last week's roll as several interfaces were removed. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=22948

Patch Set 2 : Fix expectations #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -118 lines)			Patch
	M	tests/html/html.status	View	1	4 chunks	+0 lines, -6 lines	0 comments	Download
	M	tests/html/svg_test.dart	View		5 chunks	+0 lines, -112 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm, with one html.status modification mentioned. https://chromiumcodereview.appspot.com/15404006/diff/1/tests/html/svg_test.dart File tests/html/svg_test.dart (left): https://chromiumcodereview.appspot.com/15404006/diff/1/tests/html/svg_test.dart#oldcode119 tests/html/svg_test.dart:119: group('supported_externalResourcesRequired', () { ...

7 years, 7 months ago (2013-05-21 17:08:00 UTC) #2

vsm

7 years, 7 months ago (2013-05-21 17:43:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22948 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15404006: Fix svg_test (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix expectations #

Messages